On Sat, 09 Oct 2004 00:58:00 +0100, Robert Clark <[EMAIL PROTECTED]> wrote:
> On Wed, 2004-10-06 at 15:19, Robert Clark wrote:
>
> > Oct 5 22:02:21 miller kernel: Oops: 0002 [#1]
>
> The attached (trivial) patch fixes this oops for me but I think this
> is only half the problem.
>
> What seems to have been happening is that, without the DRIVER_HAVE_DMA
> flag, dev->dma was not being initialised. This caused a problem with the
> following code in DRM(irq_install) from drm_irq.h:
>
> dev->dma->next_buffer = NULL;
> dev->dma->next_queue = NULL;
> dev->dma->this_buffer = NULL;
Dave, these variables don't seem to be in use any more. I commented
out their definitions and everything still compiles.
drmP.h
/** \name DMA support */
/[EMAIL PROTECTED] */
// drm_buf_t *this_buffer; /**< Buffer being sent */
// drm_buf_t *next_buffer; /**< Selected buffer to send */
// drm_queue_t *next_queue; /**< Queue from which buffer selected*/
// wait_queue_head_t waiting; /**< Processes waiting on free bufs */
/[EMAIL PROTECTED] */
Is this a left over from gamma maybe?
> leading to the null dereference.
>
> I assume these lines need to be wrapped in an
> if(drm_core_check_feature(dev, DRIVER_HAVE_DMA)) { } or something, but
> I'll leave that to someone who actually understands this code.
>
> Robert
>
>
>
--
Jon Smirl
[EMAIL PROTECTED]
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
