> > I've just patched this into the radeon driver (and texmem.c) > > http://freedesktop.org/~airlied/patches/dri/radeon_texturetop.patch
Okay the patch above should now work on the radeon driver, I had forgotten a call to update the texture.... Just some comments and criticisms from a quick look over it: The protocol processing code in the texturetop (server code - it is called client code but it listens on a socket which makes it a server in my mind), is fragile, starting manytex with -n 99 makes it crap out on my system, I think the processing of the buffer from the client isn't robust enough, it should probably use a proper circular buffer or a state machine based decode.. I also would wonder if a packet protocol might not be better placed for a protocol that goes between two processes where no human is going to be looking at it,, it certainly would be more efficient, <pkttype><length><info> string processing in C is always ugly..... I might get a chance to mess more with it later, my main application uses between 10s and 1000s of textures!! so it is a great way to stress it... also a sorting option like top would be nice ;-) I would like to see something like this make its way into the DRI at some stage, it could be built in at compile time if someone was worried about the overhead it might bring.. Regards, Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie pam_smb / Linux DECstation / Linux VAX / ILUG person ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
