> Am Freitag, 12. November 2004 00:06 schrieb Dieter Nützel:
> > Am Donnerstag, 11. November 2004 22:30 schrieb Roland Scheidegger:
> > > Dieter Nützel wrote:
> > > > Let me try on r200 ;-)
> > > >
> > > > Some feedback for Roland's hyperz-dri-7.patch and
> > > > hyperz-drm-14.patch. => rv path on my r200.
> >
> > Now with hyperz-drm-15.patch.
> >
> > > > First I've change only drm. -0x1002 0x514C CHIP_R200 "ATI Radeon QL
> > > > R200 8500 LE" +0x1002 0x514C CHIP_R200|CHIP_IS_RV "ATI Radeon QL R200
> > > > 8500 LE"
>
> Now, even AS R200 ;-)
> (Backed this out, too.)
>
> > > You shouldn't need this change in theory, as it should have no effect if
> > > hierarchical-z isn't used. You probably can't change only the CHIP_IS_RV
> > > bit, you need to change dri to not use hierarchical-z at the same time.
> >
> > Backed it out.
> >
> > > > +/* if (rmesa->r200Screen->chipset &
> > > > R200_CHIPSET_REAL_R200) +
> > > > rmesa->hw.ctx.cmd[CTX_RB3D_ZSTENCILCNTL] |=
> > > > RADEON_Z_HIERARCHY_ENABLE;*/ }
>
> Let this in.
>
> > > ok. That really shows that non-rv cards can be treated the same as rv
> > > cards, if hierarchical-z is just disabled. If we can't figure out how to
> > > get hierarchical-z working, this might be an option (it should also
> > > simplify things quite a bit, since hierarchical-z can have issues with
> > > some apps if they change z-test or something like that).
> >
> > Nothing changed, here.
> >
> > > > => * NO 'black horizontal lines' anylonger. - GREAT * but some speed
> > > > regression, of course
> > >
> > > but it's still faster than without hyperz, yes?
> >
> > Sure;-)
>
> > > It's of course expected
> > > that it is slower than when you got black stripes (since that's because
> > > the depth buffer wasn't cleared, so lots of incoming fragments are just
> > > discarded even though they shouldn't be discarded).
> >
> > black, is black,... ;-)
> >
> > > What did you get when using the normal path for your card? No pattern?
> >
> > I have to try, again, when I've time, again.
>
> r200
> RV path and R200 (?)
>
> Plus
>
> --- radeon_state.c.orig 2004-11-11 22:08:37.000000000 +0100
> +++ radeon_state.c 2004-11-13 14:08:32.245758629 +0100
> @@ -894,7 +894,8 @@
> }
> else {
> /* FIXME : reverse engineer that for Rx00 cards */
> - clearmask = (0xff<<22)|(0xff<<6)| 0x003f003f;
> + /* clearmask = (0xff<<22)|(0xff<<6)| 0x003f003f; */
> + clearmask = 0x0;
> }
>
> BEGIN_RING( 8 );
>
> All fine (with both paths), except of your stencil NWN pattern with
> doom3-demo, here.
>
> But if I enable RADEON_Z_HIERARCHY_ENABLE in
> src/mesa/drivers/dri/r200/r200_state_init.c, again I get the black lines
> _and_ more corruptions if I move the 3D window to the bottom (or I have a
> vertical big window).Ups, ipers-bottom.png shouldn't go to dri-devel. --- Sorry! And I've forgotten 'gears-bottom'. -Dieter
<<attachment: gears-bottom.png>>
