Am Dienstag, 1. März 2005 19:46 schrieb Roland Scheidegger:
> Dieter Nützel wrote:
> >>Looking a bit at this, this seems to be caused because the number of
> >>pixels to read can be less than zero after CLIPSPAN (don't know if
> >>that's a bug in itself or not).
> >
> > That was my first thought, too (moving the window out to the left...) ;-)
> >
> >>This is no problem for the generic read (since the for loop will just
> >>terminate instantly), but the mmx/sse/sse2 optimized routines only test
> >>if it's 0 pixels to read, and don't bail out if it's less than zero. I
> >>haven't looked closely what exactly will happen (i.e. the loops may
> >>never terminate at all), but this certainly seems like a bad thing...
>
> Here's a one-liner fix, which will cause CLIPSPAN hopefully never return
> a negative n1. Seems to work here.
> Ian, what do you think? Would it be better to have the optimized
> read/write functions deal with negative values instead?
Ian,
any thoughts?
Thanks,
Dieter
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
