Please do not reply to this email: if you want to comment on the bug, go to
the URL shown below and enter yourcomments there.
https://bugs.freedesktop.org/show_bug.cgi?id=3248
------- Additional Comments From [EMAIL PROTECTED] 2005-05-09 23:48 -------
I've been thinking about this some more. I've decided that I don't like the
idea of failing at device open. The problem is that if the MGA DRM is updated
to support PCI cards, the device open can't fail. In that case, old versions of
the DDX will go back to being broken (i.e., exactly as they are today).
After digging a bit deeper, I think a better sollution is to add a
device-specific hook in drm_agp_init. At the start of drm_agp_init,
dev->driver->agp_preinit(). agp_preinit could then determine if the card was
really an AGP card or not. If it's not, it would return false and drm_agp_init
would fail. In the case of drivers that require AGP (i.e., the current MGA
DRM), this would result in driver failing to initialize.
If nothing else, it looks like it should make the drmAgpAcquire call in the DDX
fail. That /should/ be good enough for now. In the future, when the DRM and
DDX support DRI on PCI cards, the DDX could take a different, non-failure path
when drmAgpAcquire fails.
I'll code up something in the morning and post a patch. Does this seem like the
right approach?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
