On 5/17/05, Jon Smirl <[EMAIL PROTECTED]> wrote:
> Are the FillInModes() functions working right? I found these two
> problem when I copied the code into EGL.
> 
> drivers/dri/common/util.c
> driFillInModes()
> 
>                 modes->stencilBits = stencil_bits[k];
>                 modes->depthBits = depth_bits[k];
> 
> Shouldn't that be
> 
>                 modes->stencilBits = stencil_bits[k];
>                 modes->depthBits = depth_bits[i];
> 
> i instead of k?
> 
> And in r200screen.c, r200FillInModes()
> 
>     depth_bits_array[0] = depth_bits;
>     depth_bits_array[1] = depth_bits;
> 
> Should be
> 
>     depth_bits_array[0] = 0;
>     depth_bits_array[1] = depth_bits;
> 
> This bug is probably in all of the drivers due to copying.

I think you right but maybe there is voodoo behind this.
I will try to give a look at that...

Jerome Glisse


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_idt12&alloc_id344&op=click
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to