On Fri, May 27, 2005 at 02:53:12PM -0400, Michel Dänzer wrote:
> On Fri, 2005-05-27 at 19:02 +0100, Alan Hourihane wrote:
> > >
> > > Why does the mga_drv.c set DRIVER_REQUIRE_AGP when it doesn't 'require' it
> > > if there's a PCI Matrox card ?
> > >
> > > Couldn't we do....
> > >
> > > if (drm_device_is_agp(dev) || DRIVER_REQUIRE_AGP)
> > > dev->agp = drm_agp_init(dev);
> > >
> > > and remove DRIVER_REQUIRE_AGP from mga_drv.c ?
> >
> > Oops, try again...
> >
> > if (drm_device_is_agp(dev) || drm_core_check_feature(dev,
> > DRIVER_REQUIRE_AGP))
> > dev->agp = drm_agp_init(dev);
> >
> > if (dev->agp == NULL)) {
> > DRM_ERROR("Cannot initialize the agpgart module.\n");
> > retcode = -EINVAL;
> > goto error_out_unreg;
> > }
>
> Shouldn't it be:
>
> if (drm_device_is_agp(dev))
> dev->agp = drm_agp_init(dev);
>
> if (drm_core_check_feature(dev, DRIVER_REQUIRE_AGP))
> {
> if (dev->agp == NULL)) {
> DRM_ERROR("Cannot initialize the agpgart module.\n");
> retcode = -EINVAL;
> goto error_out_unreg;
> }
> }
That's what exists at the moment, but the the drm_device_is_agp(dev)
returns 0 because it's not an AGP device but PCIE, even though the
functionality of agpgart still exists in the chipset.
You've probably seen my easier fix already which will fix this problem.
Alan.
-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
