> > Now I've hacked that code together in little over two hours (while > > watching Raiders of the lost Ark) I don't see the advantage adding all the > > macros will bring, once you've identified which structs/ioctls need work, > > a quick editor macro can generate the code nearly... (granted I'm sure > > there are bugs in what I've just done...) > > Right. Those bugs have been removed from my code already.
I've no idea if you are deliberatly missing the point (we have a manager here who says if someone doesn't understand something then you aren't explaining it clearly enough, so maybe its my fault for not being clear) The macros are never going into the Linux kernel, I have the authority to say that, Paul has backed my opinion up (both of us have submitted code to the kernel for a while), I've reimplemented your code using Pauls template and using a cross-compiler made it build on my system, I believe it works exactly like your code just using the latest kernel methods for compatible ioctls, the macros will not help in the slightest the "maintenance" of the code, and this is the job that happens most often (and mostly by me...) not the writing which has been pointed out only happens once.... this was 3 hours work for me... I've asked AlanH to throw together an i915 implementation and with that we'll be set for most of the the hardware people will initially throw at it (mach64 and savage probably being the other two).... I appreciate the work you've put into the patch and we now have code in place that builds on both yours and Pauls work, and its going to be merged to the kernel so we should all be happy about this.. The issues remaining are: a) should we provide backwards compat stuff for users of old kernels in DRM CVS, without cluttering up the nice code.. b) what size to we make handles... Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
