On Tuesday 30 August 2005 11:31, Ian Romanick wrote: > Daniel Stone wrote: > > On Mon, 2005-08-01 at 09:37 -0700, Ian Romanick wrote: > >>The only way this could happen is if *both* PTHREADS and XTHREADS are > >>defined. I suspect the Xthreads.h problem was always there, but it was > >>never hit because XTHREADS was never defined. Some how, somewhere, > >>XTHREADS is getting set. I'll have to look into it, but I think this is > >>a bug in whatever X.org header is defining XTHREADS for us. :( > > > > Yes, you're spot on about PTHREADS and XTHREADS both being defined. > > XlibConf.h now defines XTHREADS if we're using it, the consensus being > > that if you're using <X11/Xlibint.h>, you deserve everything you get. > > Which I consider to be a bug, but apparently I'm the only one. If I > wanted XTHREADS support, I'd ask for it.
You _have_ to have it defined correctly. The Xlib ABI changes based on whether it was built with XTHREADS support. We didn't have to define XTHREADS in an installed header file in the monolith because everything was built in the same pass and imake would define it for us. This is no longer the case. The s/XTHREADS/USE_&/ conversion is correct, to the extent that it lets you choose whether your libGL is threadsafe. Whether we should allow people to do that is perhaps debatable. - ajax
pgpY0xnqVTGv4.pgp
Description: PGP signature
