On Wed, 2005-11-09 at 01:59 +0000, pedro.lixo wrote:
>
> So i have this patch to warn that driver has detected correct amount
> of memory but only using 128MB. like Roland has sugested.
I like the basic idea.
> I've implemented a more complex if expression, that only allow memory
> override to lower values of 128MB. I don't know if my though's were
> correct, or if my implementation was correct.
IMHO the condition should be
if (dev->videoRam && dev->videoRam < pScrn->videoRam)
because pScrn->videoRam is the maximum the driver can use.
Also, the else clause should read
else if (dev->videoRam)
because the server output shouldn't contain anything about the override
when the VideoRam directive isn't active in the config file.
> P.S:I don't know of i'm sending this patch to the right place....
Submitting at https://bugs.freedesktop.org would be better.
--
Earthling Michel Dänzer | Debian (powerpc), X and DRI developer
Libre software enthusiast | http://svcs.affero.net/rm.php?r=daenzer
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
