On Thu, 2005-12-01 at 01:05 -0800, vehemens wrote: > > Noticed that the surface ioctl's do not have locking yet touch the ring via > radeon_apply_surface_regs.
You mean the radeon_do_cp_idle() call? You're probably right, and I don't really see the point of that call anyway. Touching the surface registers should be safe under any circumstances, but the lock may still be useful to prevent concurrent execution, e.g. with SMP. However, the DDX driver should always have the HW lock when it calls these ioctls, and I don't see anything else using them yet, so this shouldn't cause any real problems at this time. -- Earthling Michel Dänzer | Debian (powerpc), X and DRI developer Libre software enthusiast | http://svcs.affero.net/rm.php?r=daenzer ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
