Please do not reply to this email: if you want to comment on the bug, go to
the URL shown below and enter yourcomments there.
https://bugs.freedesktop.org/show_bug.cgi?id=6814
------- Additional Comments From [EMAIL PROTECTED] 2006-05-05 18:59 -------
(In reply to comment #26)
> Okay I eventually found the ppracer regression thanks to the power of git, I
> went down a couple of bad alleys in my bisections but I tracked it down to
>
> http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/main/stencil.c?r1=1.34&r2=1.35
>
> causing most of the regression, perhaps Brian or Keith can comment and
> suggest a
> fix?
The code you've committed looks good, though I think for generality it's better
to do something like
#define I915_STENCIL_MASK 0xff
and use the condition:
if ((ctx->Stencil.Xyz & I915_STENCIL_MASK) == I915_STENCIL_MASK)
The trouble with directly testing against ~0u is that an application might
specify 0xff explicitly for that value (as it knows how deep the stencil buffer
is) and we want the same behaviour in either case - the hardware only cares
about the low 8 bits.
You're correct that several other drivers are affected by the change also.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
