-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aapo Tahkola wrote:
> *cough* patch.
> 
> ------------------------------------------------------------------------
> 
> diff -uNr src_orig/engine/rendergl.cpp src/engine/rendergl.cpp
> --- src_orig/engine/rendergl.cpp      2006-08-15 18:51:23.000000000 +0300
> +++ src/engine/rendergl.cpp   2006-07-31 03:29:06.000000000 +0300
> @@ -140,6 +140,7 @@
>      const char *vendor = (const char *)glGetString(GL_VENDOR);
>      extern int floatvtx;
>      if(strstr(vendor, "ATI")) floatvtx = 1;
> +    if(strstr(vendor, "Tungsten Graphics, Inc.")) floatvtx = 1;
>      if(floatvtx) conoutf("WARNING: Using floating point vertexes. (use 
> \"/floatvtx 0\" to disable)");
>  
>      if(forcenoshaders || !strstr(exts, "GL_ARB_vertex_program") || 
> !strstr(exts, "GL_ARB_fragment_program"))

DO NOT CHECK FOR EXTENSION STRINGS IN THIS MANNER.

Using strstr by itself is just plain wrong.  What if a driver exposes
GL_ARB_fragment_program_shadow but not GL_ARB_fragment_program?  This
usually isn't an issue for ARB extensions, but there are a few EXT and
vendor extensions where this will yield incorrect results (i.e., false
positives).

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFE4kEXX1gOwKyEAw8RAj7NAJ9loBpITOENA1SOZIqXRoj5KtgnxACfZO4y
FmgyJP7xUg+yviHTWXfMfmo=
=nXey
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to