Please do not reply to this email: if you want to comment on the bug, go to
the URL shown below and enter yourcomments there.
https://bugs.freedesktop.org/show_bug.cgi?id=4707
------- Additional Comments From [EMAIL PROTECTED] 2006-10-13 17:56 -------
Commited (a bit different) to Mesa cvs.
I didn't really solve the "problem" though that the point size calculation is
always done (if Point Attenuation is "enabled"), regardless if actually points
are drawn. I'd suspect the performance hit in tcl mode is fairly small.
Not sure about swtcl though, I think something should be done about submitting
unneded point sizes.
Would something like that make sense? Going through all primitives might be a
bit on the expensive side?
diff -u -r1.32 r200_swtcl.c
--- r200_swtcl.c 13 Oct 2006 22:10:05 -0000 1.32
+++ r200_swtcl.c 14 Oct 2006 00:44:59 -0000
@@ -118,8 +118,22 @@
}
if (RENDERINPUTS_TEST( index_bitset, _TNL_ATTRIB_POINTSIZE )) {
- EMIT_ATTR( _TNL_ATTRIB_POINTSIZE, EMIT_1F, R200_VTX_POINT_SIZE );
- offset += 1;
+ int needptsz = 0;
+ if ((ctx->Polygon.FrontMode == GL_POINT) || (ctx->Polygon.BackMode ==
GL_POINT))
+ needptsz = 1;
+ else {
+ int i;
+ for (i = 0 ; i < VB->PrimitiveCount ; i++) {
+ if ((VB->Primitive[i].mode & PRIM_MODE_MASK) == GL_POINTS) {
+ needptsz = 1;
+ break;
+ }
+ }
+ }
+ if (needptsz) {
+ EMIT_ATTR( _TNL_ATTRIB_POINTSIZE, EMIT_1F, R200_VTX_POINT_SIZE );
+ offset += 1;
+ }
}
rmesa->swtcl.coloroffset = offset;
Note though that the actual (unneeded) point size calculation would still take
place, the sizes just not submitted to the hardware I think.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
