Please do not reply to this email: if you want to comment on the bug, go to
the URL shown below and enter yourcomments there.
https://bugs.freedesktop.org/show_bug.cgi?id=5714
------- Additional Comments From [EMAIL PROTECTED] 2007-01-04 11:30 -------
(In reply to comment #17)
> Created an attachment (id=7266)
--> (https://bugs.freedesktop.org/attachment.cgi?id=7266&action=view) [edit]
> patch against head
>
> Overview of the changes to the DRI interface.
>
> The big change in this patch is moving the DRI drawable hash table out
> of the DRI driver and into the libGL loader. The DRI driver shouldn't
> worry about server side resources, that's the protocol codes job.
> When the DRI driver is loaded by AIGLX, we can register for a callback
> when a window is destroyed and don't need this garbage collection, so
> the hash table is just in the way there.
>
> Furthermore in GLX 1.3, GLX drawables created using either
> glXCreatePixmap or glXCreateWindow are managed by the client and the
> client are expected to destroy these drawables once it has finished
> using them. This means that the DRI driver should not track or
> garbage collect drawables that are created this way.
>
> Also, there is currently a bug where __DRIscreen::createNewDrawable
> always adds the created drawable to the hash, even . When the DRI driver
> tries to garbage collect that drawable, it ends up freeing structures
> it didn't allocate and crashes.
I'd like to recommend a couple additional changes.
- Remove the parameters to unbindContext that you noted were unnecessary.
- Replace the dpy/screen tuple that is passed to many functions with a
__DRIscreen pointer. It appears that the dpy is passed into the driver just so
that the driver can pass it back to the loader. Instead store the dpy/screen in
the loader private __DRIscreen data (screenConfigs). This would also eliminate
all calls to getScreen.
- Remove getScreen.
Can we get this code, even as it is, committed? Maybe it would be best to have
it on a branch?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
