http://bugs.freedesktop.org/show_bug.cgi?id=10544
Summary: Install rule in linux-core Makefile seems wrong
Product: DRI
Version: XOrg CVS
Platform: Other
OS/Version: Linux (All)
Status: NEW
Severity: minor
Priority: medium
Component: libdrm
AssignedTo: dri-devel@lists.sourceforge.net
ReportedBy: [EMAIL PROTECTED]
The recently-added install target in the linux-core Makefile
in libdrm's master branch seems wrong.
Currently, it tries to install to $(O)/drivers/char/drm, where
O is the directory containing the linux source or linux headers
neccessary for building modules.
So this will put the .ko files into the linux source or headers,
neither of which should be being scanned by depmod.
With the below patch, the linux build system gets to pick where
it install the modules, and defaults to /lib/modules/kver/extra.
This location is however scanned before
/lib/modules/kver/kernel/drivers/char/drm by depmod, meaning
that the latter will be prefered. If the new ones to be installed
are to be preferred, passing INSTALL_MOD_DIR=updates for example
will install into /lib/modules/kver/updates, taking precedence
over built-with-the-kernel modules.
And INSTALL_MOD_DIR=kernel/drivers/char/drm will overwrite the
versions installed with the kernel, which I think was the
intention of the existing code?
diff --git a/linux-core/Makefile b/linux-core/Makefile
index effc206..bcab6cb 100644
--- a/linux-core/Makefile
+++ b/linux-core/Makefile
@@ -238,8 +238,7 @@ drmstat: drmstat.c
$(CC) $(PRGCFLAGS) $< -o $@ $(DRMSTATLIBS)
install:
- echo "Installing DRM modules to "$(O)
- install *.ko $(O)/driver/char/drm
+ make -C $(LINUXDIR) $(GETCONFIG) SUBDIRS=`pwd` DRMSRCDIR=`pwd`
modules_install
depmod -a
else
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
