Oliver McFadden wrote: > My thoughts are, we should unify the really common stuff... but I don't think > it's possible to unify r200_tex.c and r300_tex.c. The hardware is different, > and > the file would end up with an #ifdef on every 3rd line; it doesn't make sense > here. > > Just for really common code it does. > > I don't know what is going to happen with TTM. Maybe we should hack the r300 > driver for TTM (and someone else can do R200 and R128 (radeon) if they like) > or > maybe we should start a new DRI driver completely from scratch, with TTM and > good state handling in mind from the beginning. Then we just take the code we > need from R300 and merge it into the new DRI driver. > > Regarding indenting, I indented the driver with the Linux kernel style because > that is what matched most (but not all) of the code. The indenting was a > little > inconsistent. If you like, fell free indent the R200 or R128 (radeon) code, > too. > > I guess for TTM we'll have to wait and see what happens...
Just letting you know I've been doing a bit of thinking about the Mesa driver model lately, and I think there's room to pull a lot of stuff up and out of the drivers. Regarding textures - almost all of the texture handling for *all* of the drivers could effectively be handled by the miptree mechanism in the i915tex driver - basically everything could be made device-independent, but with the driver specifying how to lay mipmaps out within rectangular regions that are then managed in a device-independent way. The driver also provides some utilities like CopyBlit, etc, and helpers for choosing formats. I think there are a bunch of similar pieces of functionality that have built up in the drivers, simply because we aren't providing the right level of support in core mesa. Keith ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
