On Friday, June 15, 2007 4:15:57 Michel Dänzer wrote: > On Thu, 2007-06-14 at 11:37 -0700, Jesse Barnes wrote: > > Ok, I updated the branch with most of your suggestions. I think > > the ioctl still needs work (just made it a u64 for now), > > Yeah, that (first member 32 bit, second 64 bit) is exactly the same > as radeon setparam so not 32/64 safe (64 bit compiler aligns the > second member to 64 bits). > > > since at the very least we'll need to add the new one Keith > > suggested to handle CRTC reconfiguration. > > Not sure it's really needed. E.g. the driver get_vblank_counter hook > could return 0 for a disabled CRTC, so the core would handle a CRTC > getting disabled as a wraparound, and then the code disabling the > CRTC could call drm_handle_vblank to wake up its waiters.
But the code that handles disabling the CRTC doesn't exist yet, so it would either be in the X server DDX or an ioctl to the DRM driver, right? > > Please take a look and I'll test some more. I also added some > > comments to most of the new stuff, and once it's settled down I'll > > send out a note with instructions on how to update drivers (though > > I can try to do it myself, I'll probably get it wrong for some > > drivers). > > Sounds good. I pushed some minor fixes and enhancements, the rework > is proving very good at digging up longstanding bugs in this code. :) Yeah, the fixes look good, the code is actually starting to look like it might work correctly now. :) Thanks, Jesse ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
