On Wed, 2007-09-26 at 08:31 -0700, Jesse Barnes wrote: > On Wednesday, September 26, 2007 8:11:19 am Michel Dänzer wrote: > > On Wed, 2007-09-26 at 07:53 -0700, Jesse Barnes wrote: > > > On Wednesday, September 26, 2007 12:08:13 am Michel Dänzer wrote: > > > > On Tue, 2007-09-25 at 13:32 -0700, Jesse Barnes wrote: > > > > > that moves the new fields over to the drawable private. I added a > > > > > new drawable hook to implement the callback, and in the process > > > > > discovered that all the drivers I could find either set their MSC > > > > > routines to NULL or used the generic calls. > > > > > > > > > > So I didn't bother creating a new driver API hook for the new call; I > > > > > just set it directly to the version in vblank.c in > > > > > driCreateNewDrawable(). > > > > > > > > > > Would it make sense to rip out all the wrappers in dri_util.c, set > > > > > everything directly in driCreateNewDrawable() and > > > > > driUtilCreateNewScreen()? > > > > > > > > What exactly do you mean by 'all the wrappers'? > > > > > > There are wrappers in dri_util.c for this code. The drivers then point > > > their Driver API callbacks at them (rather than using the routines in > > > vblank.c directly for example), so it's just an extra level of > > > indirection that doesn't seem to buy us anything, [...] > > > > AFAICT all drivers point the DriverAPI callbacks to the vblank.c > > functions, so I'm still not sure what you're getting at, but maybe your > > patch will clarify. > > Err yeah I was describing it backwards. The __DRIscreen hooks for the MSC > stuff all point to dri_util.c wrapper functions that end up calling the > driver hooks. However, drivers always set their hooks to either NULL or to > the routines in vblank.c. So we could just set the __DRIscreen hooks to > point to vblank.c directly since none of the drivers appear to have custom > hooks for these calls...
I see, thanks for clarifying. Ian Romanick can probably tell us more about this. -- Earthling Michel Dänzer | http://tungstengraphics.com Libre software enthusiast | Debian, X and DRI developer ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
