On Thursday, September 27, 2007 3:35:22 pm Jesse Barnes wrote: > In one of my overzealous pipe/plane mapping patches, I renamed the pipes > field in drm_i915_flip_t to planes, since it's really dealing with > planes and so seemed to make sense. > > However, drm_i915_flip_t has different compatibility requirements than > the i915 sarea private. The sarea private is duplicated in the Mesa > and DDX trees and used under a different name, so changes to it, as > long as they're binary compatible, are fine. drm_i915_flip_t, on the > other hand, is used under the same name by both the Mesa and DDX trees. > > So if you build an old DDX or Mesa against a new DRM, they'll pick up > the new drm_i915_flip_t definition (since HAVE_I915_FLIP will be > defined) and promptly break. This patch reverts the DRM to the old > name and adds comments describing the actual field usage. > > Sorry for the trouble.
Oh, and for similar reasons, building a new Mesa or DDX against an old DRM will break, but keithp is making everything use the installed DRM headers all the time, so we can go back to the old drm_i915_flip_t field name then. Jesse ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
