On Monday, October 1, 2007 2:07:44 am Michel Dänzer wrote: > On Fri, 2007-09-28 at 12:31 -0700, Jesse Barnes wrote: > > Ok, this version includes the changes suggested by Michel and Ian. > > - update ABI version > > - fixup glXGetVideoSyncSGI and glXWaitVideoSyncSGI semantics > > Do you mean making sure the MSC never decreases for a given drawable? I > see you changed the comments about this, but I don't see how the code > actually ensures it. Can you elaborate?
Well, it doesn't yet, but it's supposed to. See the last exchange between idr and myself. > > - cleanup driDrawableInitVBlank prototype > > - update all drivers to the new scheme > > > > The last bit especially needs review. The changes were fairly > > mechanical, but there were some slight differences between what the > > various drivers were doing with vblank counts. > > Looks good to me. BTW, you could have saved yourself some work here by > starting after the i915-unification merge. :) Yeah. :) I don't think it'll be too hard to merge though. > > - unsigned int interval = driGetVBlankInterval(dPriv, > > intel->vblank_flags); + unsigned int interval = > > driGetVBlankInterval(dPriv, dPriv->vblFlags); > > I guess driGetVBlankInterval could be changed to take just dPriv as well > (sorry I didn't think of this before). I should have caught this too. Will fix. Jesse ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
