On Thu, 2008-03-06 at 17:58 +0000, Owain Ainsworth wrote: > Hi guys, > > By means of introduction: I'm the guy attempting to port the DRM so that > it'll run on OpenBSD. So far things are going fairly well (I don't know > how many hours i've sunk into this though). The code isn't all in our > cvs tree since it's currently locked for release. In fact the difference > between the cvs tree and what i'm using locally is rather large. > However, I thought it was about time i started sending patches back > (i've been putting it off since things weren't 100%). As a first patch, > this fixes the freebsd codepath a bit by removing some deadlocks, the > functions affected only touch the lock on a few of their exit points, > this makes sure that the lock is dealt with properly on all of them. > > This isn't tested on freebsd (I don't have a system running it), also > the current drm tree wouldn't compile on freebsd since the vblank > changes I'm debugging some patches to fix that, too. Patch is attached > inline after the rest of this mail. > > For anyone interested, here's the current status of DRI on openbsd: > - SiS apparently works (i've not heard from the guy testing it for a while > though). > - 965 (G965 and GM965) is mostly ok, but there are a few instabilities > (the hardware registers get out of sync and X crashes). There's > obviously a deadlock there also, since also sometimes things get > utterly buggered and X locks up trying to get the hardware lock (the > mouse moves, but all events get dropped as being out of order). Both of > these can be triggered by multiple renderers, and moving the application > around a lot.
Sorry for the long delay! I committed most of your work, with a couple of tweaks. I moved the lock grab in drm_addbufs_* to when it was required to avoid the need for more error path code. Also, free(9) and thus drm_free() should be just fine with being passed NULL. If it isn't, I'd recommend making drm_free work around your platform, because people generally expect free(NULL) to work. -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED]
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel