http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #7 from Roland Scheidegger <[EMAIL PROTECTED]>  2008-07-02 05:42:42 
PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > >     I915 adds some extra instructions to do fog, then turn off FogOption, 
> > > which
> > > causes the FOGC attribute of the span isn't set on mesa_7_0_branch.  This 
> > > patch
> > > fixes this issue, but I am not sure whether it breaks other driver. Could 
> > > you
> > > take a look?
> > 
> > I don't think this is entirely correct. A (user supplied) fragment program
> > could use FOGC for something else than fog.
> > 
> This patch just initializes the FOGC attribute of the span if FOGC is used as
> an input.  If a fragment used FOGC for something, it still need to initialize
> this attribute, right?

You're right I didn't look closely enough. May cause (little) unnecessary work
to be done but if fog is applied or not is not determined by this, so should
probably be ok.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to