On Tue, Jan 27, 2009 at 4:23 AM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > > Dave, > you have some odd and slightly git usage model, which shows up in various > commits. Lookie here as an example from comit 335041ed: > > Author: Jesse Barnes <jbar...@virtuousgeek.org> 2009-01-22 04:22:06 > Committer: Dave Airlie <airl...@redhat.com> 2009-01-22 04:22:06 > > drm/i915: hook up LVDS DPMS property > > The LVDS output supports DPMS calls, but we never hooked up the > property code, > so set property calls didn't actually do anything. Implement a > set_property > callback for the LVDS output so that the right thing happens. > > Signed-off-by: Jesse Barnes <jbar...@virtuousgeek.org> > > and this has a few issues that trigger my "Dave is doing something wrong" > reaction: > > - The signed-off-chain is incomplete from the author to the committer. > > A _good_ sign-off will always have the sign-offs from the author and > the committer and everybody in between. This one does not. Clearly > Jesse did sign off on his work, but he is not listed as the committer: > you are. And that means that your sign-off is missing.
This one is my fault, I think I just cut-n-pasted the commit message in my sleep, and forgot to add my signoff. > > - You are clearly lying about dates and/or dropping them. > > The dates for authorship and committing are the same, yet the author > and committer are clearly _not_ the same. You can try to convince me > that you committed Jesse's work the same second he sent it to you, but > quite frankly, I don't buy it. End result: you've done something to > drop the date information Well I'm not 100% sure what happened for this patch, I suspect, jbarnes sent patch a week or two ago, it misapplied against the tree I had currently when applied with git-am, it didn't work so I hand applied the patch with patch and then did git commit --author="jbarnes" as he did write it, I just munged it. Now I'm unsure how I should best handle this, in a world where I can devote a lot more time to maintaining this, I would sent Jesse a mail saying, rebase, he'd reply with a rebase and I'd apply it, however I generally find it easier to just fix this stuff up on the run as its synchronous. Should I be specifying a date somewhere in the commit message? Dave. ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
