On Fri, 6 Feb 2009, Jesse Barnes wrote: > In dc1336ff4fe08ae7cfe8301bfd7f0b2cfd31d20a (set vblank enable flag correctly > across IRQ uninstall), we made sure drivers that uninstall their interrupt > handler set the vblank enabled flag correctly, so that when interrupts are > re-enabled, vblank interrupts & counts work as expected. However I missed the > last_vblank field: it needs to be updated as well, otherwise, at the next > drm_update_vblank_count we'll end up comparing a current count to a stale > one (the last one captured by the disable function), which may trigger the > wraparound handling, leading to a jumpy counter and hangs in drm_wait_vblank. > > The jumpy counter can prevent the DRM_WAIT_ON from returning success if the > difference between the current count and the requested count is greater than > 2^23, leading to timeouts or hangs, if the ioctl is restarted in a loop (as > is the case in libdrm < 2.4.4). > > Signed-off-by: Jesse Barnes <jbar...@virtuousgeek.org>
Works fine on my GM965, fixing the issue I had. Tested-by: Timo Aaltonen <tjaal...@cc.hut.fi> t ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
