On Wed, 2009-02-11 at 14:29 -0800, Jesse Barnes wrote: > Michel may want to change this a bit (make the check smaller), but I'd still > like something like this to go in.
Yeah, as I've explained before, if we're changing this, we might as well go all the way and make it match the 3s timeout as closely as reasonably possible. > The current wait_vblank condition won't return if the wait sequence is > more than 8M behind the current counter. This causes problems in the > wraparound case, which can happen if vblank interrupts have been > disabled by the timer (after 5s of no waiters), but then re-enabled > after a DPMS event. Sounds like maybe the display driver isn't calling the modeset ioctl properly around DPMS events? > (An alternative fix might be to not account for lost frames between off->on > periods at all, removing the drm_update_vblank_count code entirely.) You can do with your driver whatever you please, but please leave the drm_update_vblank_count code for drivers that don't have these problems. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
