On Thu, 26 Mar 2009 11:59:13 +0100 Jakob Bornecrantz <wallbra...@gmail.com> wrote:
> On Mon, Mar 23, 2009 at 9:46 PM, Arjan van de Ven > <ar...@infradead.org> wrote: > > >From 785bb9f968ead288395ead4f921d7c1fb794ee71 Mon Sep 17 00:00:00 > > >2001 > > From: Arjan van de Ven <ar...@linux.intel.com> > > Date: Mon, 23 Mar 2009 13:34:46 -0700 > > Subject: [PATCH] KMS: register the LVDS before the CRT > > > > for the cases where the user only really cares about lighting up > > one output, or only one output at first, lighting up the LVDS > > (which only gets detected with lid-up) rather than the CRT is the > > right answer. > > > > This patch flips their order of registration so that this becomes > > possible. > > > > Signed-off-by: Arjan van de Ven <ar...@linux.intel.com> > > Not-acked-by: Jakob Bornecrantz <wallbra...@gmail.com> > > I'm going to nack this patch out of principle, getting the correct > behavior from userspace depending on the order of connectors is bad. this has nothing to do with userspace though, but all about user choice. > The interface gives you enough information to find the LVDS and turn > that on only that on. > Is there some other reason that the getting of > output name is slow? If so I would be happy to see patches that fixes > that. This patch has nothing to do with speed; it is only about registration order. LVDS-before-CRT makes total sense (as long as the lid of the laptop is not closed, which is why I added the comment); while CRT-before-LVDS does not. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org ------------------------------------------------------------------------------ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
