On Thu, 2009-05-21 at 13:21 -0700, Eric Anholt wrote: > On Wed, 2009-05-20 at 13:32 +0200, Michel Dänzer wrote: > > From: Michel Dänzer <daen...@vmware.com> > > > > Fixes a regression from commit 9d5b3ffc42f7820e8ee07705496955e4c2c38dd9 > > ('drm: fixup some of the ioctl function exit paths'): The vblank ioctl > > needs to > > update the userspace parameters when interrupted by a signal, which was > > prevented by the return code check. This could cause the X server to hang in > > drmWaitVBlank(). > > > > Signed-off-by: Michel Dänzer <daen...@vmware.com> > > Reviewed-by: Eric Anholt <e...@anholt.net> > > (The DRM ioctls are, to my memory, all built so that on error copying > the data out still is either harmless or good).
Right. Thanks for the review, Eric, and for queueing up the patch for Linus, Jesse. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel