On Fri, 2009-07-10 at 17:14 -0700, Keith Packard wrote:
> The frame buffer only has a valid address between prepare_access and
> finish_access calls, so remove all other attempts to compute an address from
> the driver.
> 
> Signed-off-by: Keith Packard <kei...@keithp.com>
> ---
>  src/drmmode_display.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 7cfdc5b..df10fb5 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -1056,12 +1056,9 @@ drmmode_xf86crtc_resize (ScrnInfoPtr scrn, int width, 
> int height)
>               goto fail;
>  
>       i830_set_pixmap_bo(screen->GetScreenPixmap(screen), 
> pI830->front_buffer->bo);
> -     scrn->fbOffset = pI830->front_buffer->offset;
>  
>       screen->ModifyPixmapHeader(screen->GetScreenPixmap(screen),
>                                  width, height, -1, -1, pitch * pI830->cpp, 
> NULL);
> -     xf86DrvMsg(scrn->scrnIndex, X_INFO, "New front buffer at 0x%lx\n",
> -                pI830->front_buffer->offset);
>  
>       for (i = 0; i < xf86_config->num_crtc; i++) {
>               xf86CrtcPtr crtc = xf86_config->crtc[i];

This one and #3 seem to be in disagreement.  Perhaps some squashing?

Other than that, it looks fine to me.

-- 
Eric Anholt
e...@anholt.net                         eric.anh...@intel.com


Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to