* Dave Airlie <airl...@linux.ie> wrote:
> > hm, i'm missing a description about how this bug was triggered.
> > How did you end up getting highmem pages to a cpa call?
>
> GEM and TTM both allocate page arrays and just pass them to cpa,
> we don't know what type of pages the allocator gives us back and
> we really shouldn't have to, so having cpa ignore highmem pages is
> certainly the right option.
>
> GEM just uses shmem code to alloc the pages and TTM has its own
> allocator.
Neither of my questions was answered though: do highmem pages ever
get passed in and what were the effects of the bug and how was it
noticed?
If no highmem pages can be passed in then the right solution is not
to ignore them silently but to add a WARN_ONCE() to enforce that
they are not used in the future either.
If they are used today then i'd like to know where exactly and
double check that all the cache attributes are consistent: as a
highmem page might be visible to user-space as well or might be
mapped via the vmalloc space, etc.
And yes, if it happens and all the other mapping aliases are fine
then ignoring them is the right solution.
Ingo
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
