On Sat, 12 Sep 2009 16:02:10 +0200 Thomas Hellstrom <tho...@shipmail.org> wrote:
> Jesse Barnes wrote: > > On Fri, 11 Sep 2009 14:33:34 -0400 > > "Kristian Høgsberg" <k...@bitplanet.net> wrote: > > > > > >> This patch adds a new flag to the drmWaitVblank ioctl, which asks > >> the drm to return immediately and notify userspace when the > >> specified vblank sequence happens by sending an event back on the > >> drm fd. > >> > >> The event mechanism works with the other flags supported by the > >> ioctls, specifically, the vblank sequence can be specified > >> relatively or absolutely, and works for primary and seconday crtc. > >> > >> The signal field of the vblank request is used to provide user > >> data, which will be sent back to user space in the vblank event. > >> > >> Signed-off-by: Kristian Høgsberg <k...@redhat.com> > >> --- > >> > > > > Looks nice, we should get this into 2.6.32. The last page flip > > patch should be approximately ready too right? IIRC the only thing > > left on the kernel side was to add some padding to the request > > struct; the rest was userland and driver specific stuff (though > > I'll have to go through the discussion to be sure). > > > Kristian, Jesse, > > This patch looks good. In particular I like the way a new spinlock is > used instead of dev->struct_mutex. > > For the vblank stuff I think we agreed that the driver cs mechanism > should do the blocking and not dri2, which means that the cs > mechanism of the supported drivers will need modification. Right, we don't want to unnecessarily block clients. -- Jesse Barnes, Intel Open Source Technology Center ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel