Am Samstag, den 12.09.2009, 23:15 +0530 schrieb Jaswinder Singh Rajput: > By handling latency variable efficiently we also get rid of this warning : > > CC [M] drivers/gpu/drm/i915/intel_display.o > drivers/gpu/drm/i915/intel_display.c: In function ‘igd_enable_cxsr’: > drivers/gpu/drm/i915/intel_display.c:1918: warning: ‘latency’ may be used > uninitialized in this function > > Signed-off-by: Jaswinder Singh Rajput <jaswinderraj...@gmail.com> Reviewed-by: Paul Menzel <paulepan...@users.sourceforge.net>
Looks good to me.
(No idea, if my line is necessary.)
> ---
> drivers/gpu/drm/i915/intel_display.c | 13 ++++++-------
> 1 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 748ed50..85a13f4 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1923,14 +1923,13 @@ static struct cxsr_latency
> *intel_get_cxsr_latency(int is_desktop, int fsb,
> for (i = 0; i < ARRAY_SIZE(cxsr_latency_table); i++) {
> latency = &cxsr_latency_table[i];
> if (is_desktop == latency->is_desktop &&
> - fsb == latency->fsb_freq && mem == latency->mem_freq)
> - break;
> - }
> - if (i >= ARRAY_SIZE(cxsr_latency_table)) {
> - DRM_DEBUG("Unknown FSB/MEM found, disable CxSR\n");
> - return NULL;
> + fsb == latency->fsb_freq && mem == latency->mem_freq)
> + return latency;
Different indentation than the original. Diff would be one line smaller.
[…]
Bests,
Paul
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
-- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
