On Wed, Oct 14, 2009 at 11:53 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote:
> [ 379.173003] WARNING: at drivers/gpu/drm/drm_crtc_helper.c:1031
> drm_helper_initial_config+0x41/0x5c [drm_kms_helper]()
> [ 379.173005] Hardware name:
> [ 379.173007] No connectors reported connected with modes
> [ 379.173008] Modules linked in: i915(+) drm_kms_helper drm i2c_algo_bit nfs
> lockd fscache nfs_acl auth_rpcgss sunrpc loop firewire_sbp2
> snd_hda_codec_intelhdmi snd_hda_codec_idt snd_hda_intel i2c_i801 i2c_core
> snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore snd_page_alloc
> processor evdev pcspkr psmouse serio_raw ext4 mbcache jbd2 crc16 sg sr_mod
> sd_mod crc_t10dif cdrom ata_generic ata_piix libata uhci_hcd scsi_mod video
> output button ide_pci_generic intel_agp firewire_ohci firewire_core crc_itu_t
> ehci_hcd ide_core e1000e thermal fan thermal_sys [last unloaded:
> scsi_wait_scan]
> [ 379.173049] Pid: 1670, comm: modprobe Not tainted 2.6.32-rc3 #3
> [ 379.173051] Call Trace:
> [ 379.173055] [<ffffffffa0398296>] ? drm_helper_initial_config+0x41/0x5c
> [drm_kms_helper]
> [ 379.173061] [<ffffffff810537b7>] warn_slowpath_common+0x77/0xa4
> [ 379.173064] [<ffffffff81053859>] warn_slowpath_fmt+0x64/0x66
> [ 379.173068] [<ffffffffa039821f>] ?
> drm_helper_probe_connector_modes+0x3f/0x75 [drm_kms_helper]
> [ 379.173071] [<ffffffffa0398296>] drm_helper_initial_config+0x41/0x5c
> [drm_kms_helper]
> [ 379.173083] [<ffffffffa03a4295>] i915_driver_load+0xe96/0xf65 [i915]
> [ 379.173093] [<ffffffffa035f346>] ? drm_get_minor+0x22d/0x27b [drm]
> [ 379.173101] [<ffffffffa035f715>] drm_get_dev+0x381/0x470 [drm]
> [ 379.173113] [<ffffffffa03c9979>] i915_pci_probe+0x10/0xd0 [i915]
> [ 379.173117] [<ffffffff811aeaf7>] local_pci_probe+0x12/0x16
> [ 379.173120] [<ffffffff811af33a>] pci_device_probe+0xc6/0xf0
> [ 379.173124] [<ffffffff8122ce5d>] ? driver_sysfs_add+0x4c/0x72
> [ 379.173127] [<ffffffff8122cfaf>] driver_probe_device+0xb0/0x162
> [ 379.173130] [<ffffffff8122d0b9>] __driver_attach+0x58/0x7b
> [ 379.173133] [<ffffffff8122d061>] ? __driver_attach+0x0/0x7b
> [ 379.173135] [<ffffffff8122c7e3>] bus_for_each_dev+0x54/0x8a
> [ 379.173138] [<ffffffff8122ce0f>] driver_attach+0x1c/0x1e
> [ 379.173141] [<ffffffff8122c116>] bus_add_driver+0xbb/0x207
> [ 379.173144] [<ffffffff8122d3b8>] driver_register+0xb6/0x124
> [ 379.173153] [<ffffffffa03e5000>] ? i915_init+0x0/0x52 [i915]
> [ 379.173156] [<ffffffff811af592>] __pci_register_driver+0x61/0xcc
> [ 379.173166] [<ffffffffa03e5000>] ? i915_init+0x0/0x52 [i915]
> [ 379.173173] [<ffffffffa035b2b6>] drm_init+0x6b/0xd1 [drm]
> [ 379.173182] [<ffffffffa03e5000>] ? i915_init+0x0/0x52 [i915]
> [ 379.173191] [<ffffffffa03e5050>] i915_init+0x50/0x52 [i915]
> [ 379.173195] [<ffffffff8100a074>] do_one_initcall+0x6e/0x186
> [ 379.173199] [<ffffffff810894a0>] sys_init_module+0xd2/0x22f
> [ 379.173202] [<ffffffff81010b42>] system_call_fastpath+0x16/0x1b
>
> An unhelpful warning, especially if we anticipate hotplug events as
> connectors are brought online.
We actually really need to do what Linus asked, and detect what the BIOS
has lit up and reuse that if we can, turning on nothing is most
definitely the wrong
answer.
At the moment I don't think the fbcon code is in anyway prepared for the hotplug
situation so if we don't detect any connected stuff reported such
failure is a requirement.
Dave.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Dave Airlie <airl...@redhat.com>
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 16 +++++++---------
> 1 files changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> b/drivers/gpu/drm/drm_crtc_helper.c
> index 1fe4e1d..54e2706 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -1017,7 +1017,7 @@ bool drm_helper_plugged_event(struct drm_device *dev)
> */
> bool drm_helper_initial_config(struct drm_device *dev)
> {
> - int count = 0;
> + int count;
>
> drm_fb_helper_parse_command_line(dev);
>
> @@ -1025,15 +1025,13 @@ bool drm_helper_initial_config(struct drm_device *dev)
> dev->mode_config.max_width,
> dev->mode_config.max_height);
>
> - /*
> - * we shouldn't end up with no modes here.
> - */
> - WARN(!count, "No connectors reported connected with modes\n");
> -
> - drm_setup_crtcs(dev);
> + /* If we are headless, we can expect to find no valid modes. */
> + if (count) {
> + drm_setup_crtcs(dev);
>
> - /* alert the driver fb layer */
> - dev->mode_config.funcs->fb_changed(dev);
> + /* alert the driver fb layer */
> + dev->mode_config.funcs->fb_changed(dev);
> + }
>
> return 0;
> }
> --
> 1.6.4.3
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
