Martin,

Sorry for not reviewing this earlier, but what about including the 
include file that defines
struct page instead of a separate declaration?

/Thomas



Martin Michlmayr wrote:
> drm/ttm fails to build on MIPS because "struct page" is not known:
> | In file included from drivers/gpu/drm/ttm/ttm_memory.c:28:
> | include/drm/ttm/ttm_memory.h:154: warning: 'struct page' declared inside 
> parameter list
> | include/drm/ttm/ttm_memory.h:154: warning: its scope is only this 
> definition or declaration, which is probably not what you want
> | include/drm/ttm/ttm_memory.h:156: warning: 'struct page' declared inside 
> parameter list
> | drivers/gpu/drm/ttm/ttm_memory.c:540: error: conflicting types for 
> 'ttm_mem_global_alloc_page'
> | include/drm/ttm/ttm_memory.h:154: error: previous declaration of 
> 'ttm_mem_global_alloc_page' was here
> | drivers/gpu/drm/ttm/ttm_memory.c:561: error: conflicting types for 
> 'ttm_mem_global_free_page'
> | include/drm/ttm/ttm_memory.h:156: error: previous declaration of 
> 'ttm_mem_global_free_page' was here
>
> Signed-off-by: Martin Michlmayr <t...@cyrius.com>
>
> ---
> Maybe it wasn't clear when I posted this a week ago but this needs to go
> into 2.6.32.
>
> --- a/include/drm/ttm/ttm_memory.h    2009-11-11 22:02:56.000000000 +0000
> +++ b/include/drm/ttm/ttm_memory.h    2009-11-11 22:04:23.000000000 +0000
> @@ -143,6 +143,7 @@
>       spin_unlock(&glob->lock);
>  }
>  
> +struct page;
>  extern int ttm_mem_global_init(struct ttm_mem_global *glob);
>  extern void ttm_mem_global_release(struct ttm_mem_global *glob);
>  extern int ttm_mem_global_alloc(struct ttm_mem_global *glob, uint64_t memory,
>
>   


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to