2009/12/15 Rafał Miłecki <zaj...@gmail.com>:
> drm/radeon/kms: add dynamic engine reclocking (v4)
>
> V2: reorganize functions, fix modesetting calls
> V3: rebase patch, use radeon's workqueue
> V4: enable on tested chipsets only, request VBLANK IRQs
>
> Fixed issue when reclocking didn't happen due to lack of IRQ. Also due
> to last patch enabling pm on all chipsets, enable dynamic reclocking
> only on these somehow tested.

Couple of comments:

1. Don't use camelCase:
+               int notProcessed = 0;

2. For older asics, you'll need to schedule the pm work in the other
irq handlers (see r100.c and rs600.c).

3. For older asics, you'll need to call radeon_pm_compute_clocks() in
their respective mode_fixup functions.

Alex

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to