> > > uses DRM_MODE_DPMS_ON for FB_BLANK_NORMAL, but DRM_MODE_DPMS_ON > > > is actually for turning output on instead of blank. > > > > > > This makes fb blank broken on my T61, it put LVDS on but leave > > > pipe disabled which made screen totally white or caused some > > > 'burning' effect. > > > > > > Cc: James Simmons <jsimm...@infradead.org> > > > Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> > > > --- > > > drivers/gpu/drm/drm_fb_helper.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c > > > b/drivers/gpu/drm/drm_fb_helper.c > > > index 1c2b7d4..0f9e905 100644 > > > --- a/drivers/gpu/drm/drm_fb_helper.c > > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > > @@ -389,7 +389,7 @@ int drm_fb_helper_blank(int blank, struct fb_info > > > *info) > > > break; > > > /* Display: Off; HSync: On, VSync: On */ > > > case FB_BLANK_NORMAL: > > > - drm_fb_helper_off(info, DRM_MODE_DPMS_ON); > > > + drm_fb_helper_off(info, DRM_MODE_DPMS_STANDBY); > > > break; > > > /* Display: Off; HSync: Off, VSync: On */ > > > case FB_BLANK_HSYNC_SUSPEND: > > > > Nak. The problem is the intel drm drivers doesn't handle it power > > management state seperate from the encoder state.
Sorry I meant the backlight power management state seperate from the encoder state. > drm_fb_helper_off() will find fb's crtc and attached encoders, then > call encoder_funcs->dpms() and turn off crtc, so for your DRM_MODE_DPMS_ON > change, it will actually turn encoder on, but what we need for > FB_BLANK_NORMAL is to turn off the display. No? FB_BLANK_NORMAL is not a full power down. Only CRTC is powerdown in this mode. FB_BLANK_POWERDOWN turns off everything. You are wondering why this is the case. If the console blanks and you go to use it again it comes back very fast. In FB_BLANK_POWERDOWN mode it takes awhile to come back for certain types of displays. I have a old Sony CRT at home. Once powered down it takes about 5 to 10 seconds to come back up. Besides this the real issue is backlight != part of encoder. A patch will be coming shortly. ------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
