On Tue, Feb 2, 2010 at 4:24 AM, Pauli Nieminen <suok...@gmail.com> wrote:
> If there is section size mismatch reusing the section object
> makes section start fail.
> Reseting the object before doing error checking prevents the
> possible flood of errors.
>
That can't be right. did you read what your patch does?
of course it'll never call the printf now.
Dave.
> Signed-off-by: Pauli Nieminen <suok...@gmail.com>
> ---
> radeon/radeon_cs_gem.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/radeon/radeon_cs_gem.c b/radeon/radeon_cs_gem.c
> index c2301ad..9bfcda0 100644
> --- a/radeon/radeon_cs_gem.c
> +++ b/radeon/radeon_cs_gem.c
> @@ -255,6 +255,7 @@ static int cs_gem_end(struct radeon_cs_int *cs,
> file, func, line);
> return -EPIPE;
> }
> + cs->section_ndw = 0;
> if (cs->section_ndw != cs->section_cdw) {
> fprintf(stderr, "CS section size missmatch start at (%s,%s,%d) %d vs
> %d\n",
> cs->section_file, cs->section_func, cs->section_line,
> cs->section_ndw, cs->section_cdw);
> @@ -262,7 +263,6 @@ static int cs_gem_end(struct radeon_cs_int *cs,
> file, func, line);
> return -EPIPE;
> }
> - cs->section_ndw = 0;
> return 0;
> }
>
> --
> 1.6.3.3
>
>
> ------------------------------------------------------------------------------
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
