From: Julia Lawall <ju...@diku.dk> Test the just-allocated value for NULL rather than some other value.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y; statement S; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ( if ((x) == NULL) S | if ( - y + x == NULL) S ) // </smpl> Signed-off-by: Julia Lawall <ju...@diku.dk> Cc: David Airlie <airl...@linux.ie> Cc: Ben Skeggs <bske...@redhat.com> Signed-off-by: Andrew Morton <a...@linux-foundation.org> --- drivers/gpu/drm/nouveau/nouveau_grctx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/gpu/drm/nouveau/nouveau_grctx.c~drivers-gpu-drm-nouveau-nouveau_grctxc-correct-null-test drivers/gpu/drm/nouveau/nouveau_grctx.c --- a/drivers/gpu/drm/nouveau/nouveau_grctx.c~drivers-gpu-drm-nouveau-nouveau_grctxc-correct-null-test +++ a/drivers/gpu/drm/nouveau/nouveau_grctx.c @@ -97,8 +97,8 @@ nouveau_grctx_prog_load(struct drm_devic } pgraph->ctxvals = kmalloc(fw->size, GFP_KERNEL); - if (!pgraph->ctxprog) { - NV_ERROR(dev, "OOM copying ctxprog\n"); + if (!pgraph->ctxvals) { + NV_ERROR(dev, "OOM copying ctxvals\n"); release_firmware(fw); nouveau_grctx_fini(dev); return -ENOMEM; _ ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
