W dniu 11 lutego 2010 23:19 użytkownik Matt Turner <matts...@gmail.com> napisał:
> 2010/2/11 Rafał Miłecki <zaj...@gmail.com>:
>> We should stop audio-state-reading timer before we turn off engine
>>
>> Signed-off-by: Rafał Miłecki <zaj...@gmail.com>
>> ---
>> drivers/gpu/drm/radeon/r600_audio.c | 16 ++++++++++++----
>> 1 files changed, 12 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/r600_audio.c
>> b/drivers/gpu/drm/radeon/r600_audio.c
>> index b1c1d34..d7f6909 100644
>> --- a/drivers/gpu/drm/radeon/r600_audio.c
>> +++ b/drivers/gpu/drm/radeon/r600_audio.c
>> @@ -147,6 +147,15 @@ static void r600_audio_update_hdmi(unsigned long param)
>> }
>>
>> /*
>> + * turn on/off audio engine
>> + */
>> +static void r600_audio_engine_enable(struct radeon_device *rdev, bool
>> enable)
>> +{
>> + DRM_INFO("%s audio support", enable ? "Enabling" : "Disabling");
>> + WREG32_P(R600_AUDIO_ENABLE, enable ? 0x81000000 : 0x0, ~0x81000000);
>
> Maybe a #define instead of using magic numbers?
I was thinking about that, actually we have much more magics in
r600_audio.c. Many masks and shifts are not defined. However I would
have to just guess some names which is acceptable, but I believe we
will get real names finally released soon. Alex wrote fixes for audio,
patches are waiting for IP review.
In this situation I prefer to just leave it as is for now. It's
probably not worth of cleaning that if this will be over-cleaned
anyway.
--
Rafał
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
