W dniu 15 lutego 2010 10:19 użytkownik Rafał Miłecki <zaj...@gmail.com> napisał: > W dniu 15 lutego 2010 06:51 użytkownik Dana Goyette > <dgoye...@calpoly.edu> napisał: >> On 02/14/2010 07:43 PM, Alex Deucher wrote: >>> On Fri, Feb 12, 2010 at 10:38 AM, Dana Goyette<dgoye...@calpoly.edu> wrote: >>> >>>> On 02/11/2010 02:00 PM, Rafał Miłecki wrote: >>>> >>>>> W dniu 11 lutego 2010 22:50 użytkownik Rafał Miłecki<zaj...@gmail.com> >>>>> napisał: >>>>> >>>>>> --- >>>>>> drivers/gpu/drm/radeon/radeon_pm.c | 57 >>>>>> +++++++++++------------------------ >>>>>> 1 files changed, 18 insertions(+), 39 deletions(-) >>>>>> >>>>> Dave you can add >>>>> Signed-off-by: Rafał Miłecki<zaj...@gmail.com> >>>>> of course, if you wish. Forgot that. >>>>> >>>>> >>>> Hmm, something to watch out for: what about cards that offer more than one >>>> battery state? Take my RV635 (Mobility HD3650), for example -- my card has >>>> two battery states with different frequencies. >>>> >>> They are for different things. The dmesg output doesn't print out the >>> full power state info. Most likely one is for video playback that has >>> slightly different performance or bandwidth requirements compared to >>> the regular battery state. >>> >>> Alex >>> >> On that note, how do you define which is the "regular" battery state? >> Right now, the PM code seems to miss the lowest-speed state, and thus >> doesn't save as much power as it ideally would. > > We use lowest one for MINIMUM, which is dpms off. > > I think we could try to use MINIMUM for GPU idle, and something ever > lower for dpms off. > > I'm really busy now with my study exam, but will back to hacking this week.
To make it clear: PM_ACTION_MINIMUM is used for dpms off. It uses POWER_STATE_TYPE_BATTERY, the lowest mode PM_ACTION_DOWNCLOCK is used for GPU idle. It uses POWER_STATE_TYPE_POWERSAVE, middle mode. PM_ACTION_UPCLOCK for rest, uses default. I think we could use the lowest mode from POWER_STATE_TYPE_BATTERY for PM_ACTION_DOWNCLOCK (GPU idle), and something even lower for PM_ACTION_MINIMUM. -- Rafał ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
