On Fri, Mar 19, 2010 at 8:43 AM, Pauli Nieminen <suok...@gmail.com> wrote: > On Fri, Mar 19, 2010 at 2:35 AM, Dave Airlie <airl...@gmail.com> wrote: >> From: Dave Airlie <airl...@redhat.com> >> >> We can get this if the user moves the mouse when we are waiting to move >> some stuff around in the validate. Don't fail. >> >> Signed-off-by: Dave Airlie <airl...@redhat.com> >> --- >> drivers/gpu/drm/radeon/radeon_cs.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c >> b/drivers/gpu/drm/radeon/radeon_cs.c >> index 8d99f70..3346d9e 100644 >> --- a/drivers/gpu/drm/radeon/radeon_cs.c >> +++ b/drivers/gpu/drm/radeon/radeon_cs.c >> @@ -239,7 +239,8 @@ int radeon_cs_ioctl(struct drm_device *dev, void *data, >> struct drm_file *filp) >> } >> r = radeon_cs_parser_relocs(&parser); >> if (r) { >> - DRM_ERROR("Failed to parse relocation !\n"); >> + if (r != -ERESTARTSYS) >> + DRM_ERROR("Failed to parse relocation %d!\n", r); >> radeon_cs_parser_fini(&parser, r); >> mutex_unlock(&rdev->cs_mutex); >> return r; >> -- >> 1.6.6.1 > > Do we want to interrupt the parser? > > If we do then user space needs updating so mesa/ddx knows to submit cs > again if return code is showing that parsing was interrupted. >
Forget that comment. I was somehow reading it as -EINTR. ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel