On Sun, Mar 28, 2010 at 10:55:14PM +0200, Andi Kleen wrote: > , Dan Carpenter wrote: >> >> In the original code we used "j" as an iterator but we used "i" as an >> index. >> >> - for (j = 0; j< i; j++) >> - device_remove_file(&connector->kdev, >> -&connector_attrs[i]); > > I guess this really should be a attribute group anyways? > > Typically when there's such a open coded loop it means the wrong > interfaces are being used.
My graphics card is crap and doesn't use this code at all. I'd feel uncomfortable those changes without being able to test it. So while, you are probably right, someone else should probably do that. regards, dan carpenter > -Andi ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
