smatch: radeon: unsigned is never less than zero

[Dan Carpenter]

Hi list,

Smatch complains about this:

drivers/gpu/drm/radeon/radeon_display.c +563 radeon_compute_pll_legacy(115)
                 warn: unsigned 'error' is never less than zero.

   561                      if (pll->flags & RADEON_PLL_PREFER_CLOSEST_LOWER) {
   562                              error = freq - current_freq;
   563                              error = error < 0 ? 0xffffffff : error;
                                                                ^^^^^^^^^
        "error" is unsigned so it's never less than zero here.

   564                      } else
   565                              error = abs(current_freq - freq);

regards,
dan carpenter

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel