On Fri, 02 Jul 2010 17:19:18 +0100, Chris Wilson <ch...@chris-wilson.co.uk> 
wrote:
> On Fri, 02 Jul 2010 11:54:44 -0400, Keith Packard <kei...@keithp.com> wrote:
> > On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson <ch...@chris-wilson.co.uk> 
> > wrote:
> > 
> > > This looks like the responsibility of miCloseScreen(). Are we failing to
> > > chain up properly?
> > 
> > I don't think miCloseScreen (or fbCloseScreen) can do this -- before
> > we're called, rendering may not have been finished, after we're called,
> > the acceleration code is shut down and pixmaps cannot be freed.
> 
> That sounds true, and deserves a comment in the code. It doesn't explain
> why fbCloseScreen() calls free(screen->devPrivate) instead of
> miCloseScreen() and causing the leak in the first place... :)

yeah, miCloseScreen frees the pixmap, but that's too late...

-- 
keith.pack...@intel.com

Attachment: pgpPWn9NNXAwH.pgp
Description: PGP signature

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to