----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14015/ -----------------------------------------------------------
(Updated Sept. 24, 2013, 9:13 a.m.) Review request for drill. Repository: drill-git Description ------- Have added drill functions to MathFunctions for floor and ceil methods. Have tested the method with the below queries: 0: jdbc:drill:schema=parquet-local> SELECT ceil(1.768) as ceil_value FROM "sample-data/region.parquet"; +-------------+ | CEIL_VALUE | +-------------+ | 2.0 | | 2.0 | | 2.0 | | 2.0 | | 2.0 | +-------------+ 5 rows selected (0.638 seconds) 0: jdbc:drill:schema=parquet-local> SELECT floor(1.768) as floor_value FROM "sample-data/region.parquet"; +--------------+ | FLOOR_VALUE | +--------------+ | 1.0 | | 1.0 | | 1.0 | | 1.0 | | 1.0 | +--------------+ 5 rows selected (0.485 seconds) Diffs (updated) ----- common/src/main/java/org/apache/drill/common/expression/fn/MathFunctions.java ee3a099 exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 288760b exec/ref/src/main/java/org/apache/drill/exec/ref/eval/fn/MathEvaluators.java 347a4f3 exec/ref/src/test/java/org/apache/drill/exec/ref/RunSimplePlan.java f4992e0 exec/ref/src/test/resources/math_ceil_floor.json PRE-CREATION Diff: https://reviews.apache.org/r/14015/diff/ Testing ------- Testing done on sqlline prompt. Testing done by test case: $ mvn test -Dtest=RunSimplePlan#mathCeilFloorPlan Thanks, Yash Sharma
