[
https://issues.apache.org/jira/browse/DRILL-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818350#comment-13818350
]
Jacques Nadeau commented on DRILL-265:
--------------------------------------
I didn't see this on reviewboard so I'll add code comments here. You're
currently throwing and then catching an exception. It would be much cleaner to
simply create a new exception and pass it to logger.error and context.fail and
remove the extraneous throw & catch.
> Screen operator silently ignores selection vector in its incoming record batch
> ------------------------------------------------------------------------------
>
> Key: DRILL-265
> URL: https://issues.apache.org/jira/browse/DRILL-265
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Mehant Baid
> Assignee: Mehant Baid
> Priority: Minor
> Attachments: DRILL-265.patch
>
>
> If any child of the Screen operator adds a selection vector to its record
> batch. The screen operator ignores the selection vector and outputs all the
> data (even the ones not present in the selection vector). It should do one of
> the following
> 1. Throw an exception indicating it does not handle selection vector 2
> 2. Handle the selection vector. Project handles the selection vector, we
> could possibly leverage some of the logic.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
