[ 
https://issues.apache.org/jira/browse/DRILL-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819251#comment-13819251
 ] 

Jason Altekruse commented on DRILL-290:
---------------------------------------

I had started work on this issue when creating the writer for the Parquet 
format. Without having written a writer, I believe I might have jumped the gun 
on engineering a solution to generalize the readers and writers. I am not going 
to post a patch, because the work has not reached a level of completion 
warranting it, but here is a link to a git branch on my fork with my changes 
made the parquet reader to start this interface definition. I may revisit this 
issue if it seems like it is worthwhile after completing a few of the writers 
and readers for other formats.

https://github.com/linuxN00b92/incubator-drill/tree/writer_interface

> Generalize similarities between readers and writers
> ---------------------------------------------------
>
>                 Key: DRILL-290
>                 URL: https://issues.apache.org/jira/browse/DRILL-290
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Jason Altekruse
>            Priority: Minor
>
> Writers and readers share a lot of common code. Defining a clear interface to 
> describe different file types would allow for a cleaner implementation of 
> readers and writers for multiple formats. This would also reduce code 
> redundancy and hopefully make all of the storage engines easier to maintain 
> as formats evolve.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to