----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16738/ -----------------------------------------------------------
Review request for drill. Repository: drill-git Description ------- This patch contains the barebones for supporting decimal type. It contains modifications to template files and tdd to generate the Holder and Vector representation for Decimal type (Decimal4, Decimal8, Decimal12, Decimal16). For ease of review, I've added a couple of generated classes Decimal16Holder, Decimal16Vector here. Since these are compile time generated classes it wouldn't show up in reality. I'd like to get some feedback on the holder and vector representation (Decimal16Holder, Decimal16Vector). The Decimal16Vector class is pretty much like most vector representation since its generated using codegen, the get(), set() methods are the ones that are different. Here is a link to a design note that talks about the representation used for decimal type: https://docs.google.com/document/d/1koDaE4CviLWpKyfdNFQZ6PqkFbbwXC45lGtehcihVmQ/edit?usp=sharing Diffs ----- exec/java-exec/src/main/codegen/data/ValueVectorTypes.tdd 88a5974 exec/java-exec/src/main/codegen/templates/FixedValueVectors.java c357dd6 exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 051c62d exec/java-exec/src/main/codegen/templates/ValueHolders.java 41dc049 exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/Decimal16Holder.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/vector/Decimal16Vector.java PRE-CREATION Diff: https://reviews.apache.org/r/16738/diff/ Testing ------- Thanks, Mehant Baid
