Hello All,
The following changes are required for Compiling Drill from sourceUnder
"Compile the code", the following needs to be added under windows "del /s
contrib/sqlline/target/dependencies"Under "Run the interactive Drill shell",
the following needs to be added under windows "./sqlline.bat -u
jdbc:drill:schema=parquet-local -n admin -p admin"Is protobuf required for
Windows platform as well (I don't see any discussion on protobuf for mac osx)?
If it is required, then a section need to be added for windows and a link to
https://code.google.com/p/protobuf/downloads/detail?name=protoc-2.5.0-win32.zip&can=2&q=
need to be provided for download of protobuf.ContributingWhat is the use case
of applying a patch file in Drill project (My understanding is, if code changes
are done in production server, the diff file from that server may be used to
apply the patch in the repository)? In the statement "In JIRA, use attach file
no notify that you've submitted a patch for that issue", "attach file" may be
replaced by "More -> Attach Files"Should the patch file be loaded to both
review board and jira?In the following text from the wiki, can someone
elaborate where the highlighted "Submit Patch" button is located (For my
changes, I used "update -> Upload Diff" option of Apache Review Board)?Updating
a patchFor patch updates, our convention is to number them like
DRILL-1856.1.patch.txt, DRILL-1856.2.patch.txt, etc. And then click the "Submit
Patch" button again when a new one is uploaded; this makes sure it gets back
into the review queue. Appending '.txt' to the patch file name makes it easy to
quickly view the contents of the patch in a web browser.
Regards,Ravi
