----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17881/ -----------------------------------------------------------
Review request for drill. Repository: drill-git Description ------- Hash functions need to override NULL_IF_NULL handling of optional values to allow nulls to be inserted into hash tables. Diffs ----- common/src/main/java/org/apache/drill/common/expression/ExpressionValidator.java 11d97e8 common/src/main/java/org/apache/drill/common/expression/ValueExpressions.java 9137356 common/src/main/java/org/apache/drill/common/expression/visitors/AbstractExprVisitor.java 711bdb8 common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java 128f284 common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java 02ce231 common/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java db34ab7 common/src/main/java/org/apache/drill/common/expression/visitors/SimpleExprVisitor.java 65a939b exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java 46dbbe9 exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 36433ad exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashFunctions.java 76683f3 exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNull.java a042a5a exec/java-exec/src/main/java/org/apache/drill/exec/resolver/ResolverTypePrecedence.java 26ac961 exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java b16d1ff exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java 25daa7a exec/ref/src/main/java/org/apache/drill/exec/ref/eval/SimpleEvaluationVisitor.java 1b04880 Diff: https://reviews.apache.org/r/17881/diff/ Testing ------- Thanks, Jason Altekruse
